modinfo

[Asle]

I've patched slightly AHX to support HVL musics now.
Just so you know

[Axxy]

I've patched slightly AHX to support HVL musics now.
Just so you know

Any progress on adding Fasttracker modinfo yet?

[Asle]

afraid not. Maybe I can quickly hack something up, concentrating on instruments first.
I'll try something later today, if possible.

[Axxy]

Would be nice for the 2nd most popular format after protracker ...

[Asle]

OK, well, first shot is not working as expected, so, not online.
I'm done for the day. I'm generating too many stupid PHP bugs, so, it's time to stop
I'll look at it tomorrow, with fresh eyes.

[Asle]

It's online for XM now. Instruments names are displayed and size calculation is also done. However, if the XM is missing some data, it could lead to wrong calculation.
Please, report problems, if any.

Sylvain

[Axxy]

It's online for XM now. Instruments names are displayed and size calculation is also done. However, if the XM is missing some data, it could lead to wrong calculation.

Very nice and well done! 

But.... 

Please, report problems, if any.

It seems to show the Instrument text correctly, but it shows the Instrument details incorrectly, as it uses the sample column headings and no data. If that is the intention, then its no problem.

Must be pretty difficult to show all the Instrument/Sample texts/data etc. for all slots in XM files. Must be very problematic.

[Asle]

Instrument details are .. well, not what I wish. In XM, information like volume, size, rate (etc.) are stored at the sample level. As such, retrieving them up would make sense only if there was _one_ sample in a given instrument.
I chose, for the moment, to display nothing in there.
Maybe I could patch complete data if there's only one sample and tag the others as 'more than one sample'.

I still think displaying differently is necessary, for that kind of format. For now, it's the usual mask to display information.

Sylvain

[Axxy]

Instrument details are .. well, not what I wish. In XM, information like volume, size, rate (etc.) are stored at the sample level. As such, retrieving them up would make sense only if there was _one_ sample in a given instrument.
I chose, for the moment, to display nothing in there.
Maybe I could patch complete data if there's only one sample and tag the others as 'more than one sample'.

I still think displaying differently is necessary, for that kind of format. For now, it's the usual mask to display information.

Sylvain

I see the problem. Do any other module format do anything similar internally?

Otherwise, you'd have to show everything for both sample and instruments, both could potentially be 128 rows deep or more?  I've not really paid attention to how many rows .xm mods can contain info.

I was looking at how you do .it modules and wondered if splitting the data could be a possibility somehow?

[Asle]

IT and DBM have instruments as well. I don't remember, off hand, how it works for IT. DBM was no problem.

Regarding XM, I'm not sure I understand your comment. 128 rows could be a reference to pattern data ?
Nevertheless, there can be 128 instruments in a XM, and each instruments can store 16 samples. The concept is the following : for this instrument, which sample should be played when a given note is played. As such, you have a map of notes where you assign sample numbers (in the current instrument). Hence the specific information related to each sample. Instruments, here, are some kind of envelope only.

Now, yes, I believe the display mask must be changed. The more I think about it, the more I leaning toward something like that:
instrument 1 -
----sample 1 (sample data)
----sample 2 (sample data)
instrument 2 -
etc.

could take some time to write, though.

[Axxy]

Regarding XM, I'm not sure I understand your comment. 128 rows could be a reference to pattern data ?

Sorry, I meant only how many slots/rows of data to show in the Info details when I click the Info button. 128 Instruments or 128 Samples slots/rows if the author filled all the details in the module.  Obviously, when I clicked Info, I was expecting to see possibly up to 128 slots/rows displayed for Instruments and then 128 slots/rows for Samples.

When I started looking through a few xm's, I realised it was not practical to show instruments and samples or the page would need to be scrolled down considerably.  Looking at Awesome' For a New World II.xm, it would have to display 128 instrument slots/rows and 328 sample slots/rows...  I just didn't know that each instrument could store 16 samples...

[Asle]

All right, I misunderstood indeed !
Well, the display can be huge. That's for sure. The very max would be 128*16 lines for every sample and 128 more for instruments. That's a grand total of 2176 lines to display .
Besides, the text in sample is rarely meaningful.

[Axxy]

Besides, the text in sample is rarely meaningful.

Yeah, was just noticing that.  At least its showing that text in the Instruments which is a damn sight better than nothing at all.. 

[Asle]

And there was a bug in the XM modinfo related to the 256 stored patterns possibility. Sorry.