group names with '&' can't be clicked

Started by Asle, August 26, 2009, 21:35:35

Previous topic - Next topic

Asle

as reported some time ago, groups containing '&' or weird symbols, can't be clicked (to get the complete list of authors in this group).
This is a major problem, using group names in links, instead of IDs. Fixing this is not easy, as some rewriting of somepart of the core of AMP is needed. Still, I'm on it :)

Sylvain

Asle

done.
Please, report problems if you find any.

Crown

Works fine.  :)

I like the group+acronym+logo page. congrats!

Asle

right, well, this is mostly Monty's work, so ...

deus-ex

This is not an attempt to lessen the efforts that have been invested into this issue, but isn't replacing "&" with "and" in group names just kind of a hack/clutch rather than a real fix as it doesn't preserve the original spelling? ::) Somehow I don't feel comfortable with this. Then again probably other solutions are to costly to implement?
Best regards
deus-ex

Asle

I'm not sure I understand. The "fix" was to trash to PHP code that provided links with group names, instead of ID, which should have been done in the first place. This was certainly no cheap update, as I spent two evenings on this one. Some code from the core of AMP had to be rewritten. So, that makes it the "costly to implement" solution, from my point of view.
Then again, I may have misunderstood what you said.
Still, that was fun, as I spent all the time IRC-ing with Monty :). Good time.

deus-ex

For example searching for group CNCD gives following result:

  Now: Carillon and Cyberiad (CNCD)
Then: Carillon & Cyberiad (CNCD) <- original spelling

Got me now? :)
Best regards
deus-ex

Asle

#7
That was due to one of the admin, changing the name. It's unrelated to the present update. I've changed the name again and you can see there's a & again. It doesn't affect the way it works at all.
Any other wrong name you've noticed ?
Just quick search for '&' and some result appear. No many, right, but that's not my doing :). Searching for ' and ' brings more result. If a name is wrong, just tell me

And thanks for your feedback ! :)

deus-ex

Quote from: Asle on August 29, 2009, 12:08:21That was due to one of the admin, changing the name.

That admin is being punished/tortured as we speak, I presume? ;D


Quote from: Asle on August 29, 2009, 12:08:21Any other wrong name you've noticed ?

Checking group names containing a "&" character I found these to be affected, too:

Defpaccers & Paranoid (DPAD)
Dual Crew & Shining (DCS)
Hugo & Mamuttene (H^M)
Panic & Agnostic Front (PAF)
Success & The Ruling Company (SCS*TRC)
Tristar & Red Sector Inc. (TRSI)
Best regards
deus-ex

Asle

all renamed. Thanks !
I'll have a few words with this admin, once he is within reach :).